Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the repo’s “pipeline source contract” hygiene by adding automation to keep Copilot instructions and the manifest in sync, and updates a few CDN examples/documentation to better reflect current behavior.
Changes:
- Extend
check-copilot-sync.shwith an advisory check that warns when example projects exist on disk but aren’t tracked inmanifest.json. - Fix CDN example response-body replacement to use the incoming
body_sizewhen callingset_http_response_body. - Add a PR-triggered GitHub Actions workflow to run the sync check, and add initial
.github/copilot-instructions.md.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| fastedge-plugin-source/check-copilot-sync.sh | Adds “example directories tracked in manifest” advisory check and tightens doc-path matching logic. |
| examples/cdn/md2html/src/lib.rs | Uses body_size when replacing the full response body. |
| examples/cdn/custom_error_pages/src/lib.rs | Uses body_size when replacing the full response body; updates callback param name. |
| examples/cdn/cors/src/lib.rs | Updates module-level configuration docs to clarify dormant behavior when unset. |
| .github/workflows/copilot-sync.yml | Adds a workflow to run the sync checker on relevant PR changes. |
| .github/copilot-instructions.md | Introduces repo-specific PR review instructions and a mapping table for generated docs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+15
to
+22
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v5 | ||
|
|
||
| - name: Check manifest ↔ copilot-instructions sync | ||
| run: bash fastedge-plugin-source/check-copilot-sync.sh |
ruslanti
approved these changes
May 6, 2026
qrdl
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.