Skip to content

Fix/cdn app generation#67

Open
godronus wants to merge 7 commits intomainfrom
fix/cdn-app-generation
Open

Fix/cdn app generation#67
godronus wants to merge 7 commits intomainfrom
fix/cdn-app-generation

Conversation

@godronus
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 20, 2026 11:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the repo’s “pipeline source contract” hygiene by adding automation to keep Copilot instructions and the manifest in sync, and updates a few CDN examples/documentation to better reflect current behavior.

Changes:

  • Extend check-copilot-sync.sh with an advisory check that warns when example projects exist on disk but aren’t tracked in manifest.json.
  • Fix CDN example response-body replacement to use the incoming body_size when calling set_http_response_body.
  • Add a PR-triggered GitHub Actions workflow to run the sync check, and add initial .github/copilot-instructions.md.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
fastedge-plugin-source/check-copilot-sync.sh Adds “example directories tracked in manifest” advisory check and tightens doc-path matching logic.
examples/cdn/md2html/src/lib.rs Uses body_size when replacing the full response body.
examples/cdn/custom_error_pages/src/lib.rs Uses body_size when replacing the full response body; updates callback param name.
examples/cdn/cors/src/lib.rs Updates module-level configuration docs to clarify dormant behavior when unset.
.github/workflows/copilot-sync.yml Adds a workflow to run the sync checker on relevant PR changes.
.github/copilot-instructions.md Introduces repo-specific PR review instructions and a mapping table for generated docs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/copilot-sync.yml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@godronus godronus requested review from qrdl and ruslanti April 20, 2026 12:11
Comment on lines +15 to +22
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v5

- name: Check manifest ↔ copilot-instructions sync
run: bash fastedge-plugin-source/check-copilot-sync.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants