fix(review): restore repository and launch error handling - #2837
Open
guantw wants to merge 5 commits into
Open
Conversation
Preserve repository ownership failures as a stable error code across Review platform commands and reuse the shared trust classifier. Translate the code into actionable localized copy and route user-initiated retries through the existing trust recovery flow. Cover trust classification and localized error handling with backend and frontend regression tests.
Translate dialog-turn start failures in the Review action bar while preserving specific backend reasons. Allow multiline error details to wrap without truncation using the current theme tokens. Cover error classification, localization, component wiring, and layout behavior.
Resolve explicit file and directory scopes against the active local or remote workspace before starting Review. Return localized missing-target feedback and forward the optional remote connection scope through the existing path-existence API. Cover target resolution, service handling, and API forwarding with regression tests.
Restrict Review platform trust recovery to explicit refresh and retry actions. Share localized launch error presentation across action headers and notifications while retaining structured keys and backend reasons. Keep unsupported remote Review targets free of path probes, preserve local missing-target and Git evidence handling, and cover the interaction boundaries with regression tests.
Use OpenBitFun in absolute workspace path fixtures so the target resolver tests comply with the product identity audit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git_repository_untrustedand show localized, actionable errors in the Review platform panel. Automatic snapshot/context loads only display the error; explicit refresh and retry actions use the existing consent-based trust recovery flow.Related: #2746.
Type and Areas
Type: Regression fix.
Areas: Rust integration services, Core compatibility facade, desktop/Tauri commands, Web UI Review panels and launch flow, and en-US/zh-CN/zh-TW locales.
Motivation / Impact
Repository ownership failures otherwise surface as raw Git diagnostics, action-start errors can show inconsistent untranslated text across the header and notification, and nonexistent explicit targets lack useful feedback. The updated behavior makes these failures actionable while keeping trust prompts tied to explicit panel actions and preserving the current remote Review capability boundary.
Verification
pnpm --dir src/web-ui exec vitest runwith--maxWorkers=50%. Coverage includes Git trust recovery/presentation, Review platform linking and mounted-panel trust interactions, action-bar formatting/rendering/i18n/layout, launch errors, explicit-target resolution, ReviewService, and SystemAPI.pnpm run check:web: passed, including type checking, Canvas SDK, typography, Appearance, theme color, and visual contract checks.pnpm run i18n:audit: passed with zero warnings.cargo test --locked -p openbitfun-services-integrations --no-default-features --features review-platform --lib repository_trust: 4 passed.cargo test --locked -p openbitfun-services-integrations --no-default-features --features review-platform --lib ordinary_git_failure_remains_an_invalid_repository_error: 1 passed.cargo test --locked -p openbitfun-services-integrations --no-default-features --features git --lib git::trust::tests: 19 passed.cargo check --locked -p openbitfun-core --no-default-features --features review-platform: passed.cargo test --locked -p openbitfun-desktop --lib api::review_platform_api::tests. With the test-artifact workaround below,api::review_platform_api::testspassed 4 tests andpath_probe_payloads_accept_optional_remote_scopepassed 1 test.pnpm run check:core-boundaries: passed.git diff origin/main...HEAD --check: passed.Reviewer Notes
STATUS_ENTRYPOINT_NOT_FOUNDon this machine. This workaround affects only the test artifact and is not included in the PR. Existing matching sherpa-onnx 1.13.4 libraries were used for linking.Checklist