fix(ci): recover desktop package retries and show artifact downloads - #2826
Closed
GCWing wants to merge 1 commit into
Closed
fix(ci): recover desktop package retries and show artifact downloads#2826GCWing wants to merge 1 commit into
GCWing wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop Package retries can fail before any build when checkout_ref is absent from the checked-out branch history. The prepare job now fetches that ref explicitly, pins its commit, and retains the immutable release-tag check. Every successful platform also records its artifact download link and source SHA in the job summary.
Type and Areas
Bug fix; desktop release workflow and release-source resolution.
Motivation / Impact
Run 33969819231 lost its macOS ARM64 hosted runner. Later attempts could not load a reusable workflow from the old snapshot; a fresh dispatch then failed because the requested old commit was not present locally. A separate retry correctly rejected a tag/source mismatch. This change makes available refs recoverable and gives actionable errors for unavailable refs and tag mismatches. The release guide explains when a fresh full run is needed after artifacts disappear.
Existing tag bindings, Apple signature verification, protected-main ancestry checks, and the requirement that all platforms succeed before Release publication remain enforced. Runner loss itself is an infrastructure failure, not a proven compiler defect; the original artifact deletion cause is still unknown.
Verification
Reviewer Notes
AI-assisted; focused local checks passed. Native macOS/Windows package reruns are tracked separately in Actions. No product runtime behavior changed, and remote workspace/control/peer/dispatch scenarios were not exercised.
Checklist