fix(web-ui): support font size shortcuts and disable printing - #2870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
=key and numeric keypad add/subtract keys.Type and Areas
Type: Bug fix / UI/UX
Areas: Web UI, shared desktop frontend
Motivation / Impact
Users can adjust typography with familiar keyboard shortcuts, including while an input or editor is focused. Each press changes the base font size by 1px within the existing 12–20px range and saves it through the existing font preference service.
Print shortcuts no longer open the browser print dialog.
Verification
pnpm --dir src/web-ui run test:run src/app/browserShortcutPolicy.test.ts src/infrastructure/font-preference/core/FontPreferenceService.test.ts src/infrastructure/font-preference/components/FontPreferencePanel.test.tsxpnpm run check:webgit diff --checkReviewer Notes
Reuses the existing font preference schema and typography tokens; no migration or new host API is required.
Platform keyboard behavior was covered by automated DOM tests. Native Windows/macOS clients and remote workspace, remote control, Peer Device Mode, and Detached Dispatch scenarios were not manually exercised.
Checklist