fix(settings): align concurrency inputs with host validation limits - #2873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align tool execution concurrency inputs with the host validation limits: 1–32 for subagents and 1–64 for Swarm. Normalize edited values to valid integers and show the host error when saving fails.
Type and Areas
Type: Bug fix
Areas: Web UI settings, tests
Motivation / Impact
The settings UI previously accepted values up to 100, while the host rejected subagent concurrency above 32 and Swarm concurrency above 64. Entering 50 for subagents therefore produced a generic save failure.
Inputs now use the supported bounds, and decimal input is rounded before saving. Failed saves restore the previous value and display the underlying error.
Verification
Validation completed:
pnpm --dir src/web-ui exec vitest run src/infrastructure/config/components/RuntimeSettingsPages.test.tsx src/infrastructure/config/components/RuntimeSettingsPages.presentation.test.ts— 18 tests passed.pnpm run check:webgit diff --checkReviewer Notes
Checklist