fix(ssh): align parent directory row layout - #2876
Merged
Merged
Conversation
Reuse the remote file browser name-cell layout and typography for the parent-directory entry so its icon and label have consistent spacing and vertical alignment. Preserve the smaller navigation icon, spanning cell, and parent navigation behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the cramped icon and
..label in the remote workspace directory picker by reusing the existing name-cell layout and typography.Type and Areas
Type: Bug fix / UI/UX
Areas: Web UI, SSH remote file browser
Motivation / Impact
The parent-directory row omitted the flex wrapper and name styling used by ordinary directory entries, leaving its icon and label without the intended spacing and vertical alignment. Apply those shared styles while preserving the smaller navigation icon, spanning cell, and existing parent-directory navigation behavior.
Verification
pnpm run type-check:web— passed after rebasing onto the latestmain.pnpm run check:web:appearance— passed after refreshing the local design-system build outputs.git diff --check origin/main...HEAD— passed.Reviewer Notes
Only
RemoteFileBrowser.tsxchanges. No path handling, SSH operations, persistence, or user-facing strings change.Verification is local and static. Live remote workspace, remote control, Peer Device Mode, and Detached Dispatch scenarios were not exercised. The development application was not launched.
Checklist