fix(web-ui): isolate sidebar navigation stacking - #2877
Merged
Conversation
Keep sticky session headers inside the main navigation stacking context when reduced motion removes its transform. This prevents headers from painting above the file navigation overlay while preserving sticky positioning and navigation state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
isolation: isolateto the main sidebar navigation layer so sticky session headers remain below the file navigation overlay when reduced motion removes the layer's transform.Type and Areas
Type: Bug fix
Areas: Shared Web UI / sidebar navigation
Motivation / Impact
The file navigation overlay keeps the main navigation mounted to preserve session-list state. Its sticky headers have a higher z-index than the overlay, so they can paint above the file tree when reduced motion removes the transform that previously contained them. An explicit stacking context keeps the overlay on top while preserving sticky positioning, navigation transitions, and scroll state.
Verification
After rebasing onto
origin/mainat8f6ddaf8a:pnpm --dir src/web-ui run test:run src/app/components/NavPanel/NavPanelLayout.test.ts src/app/components/NavPanel/components/StickySectionHeader.test.tsx— 11 tests passed.pnpm run check:web— passed.git diff origin/main...HEAD --check— passed.Before rebase, the desktop frontend build and Windows Debug build also passed. The Debug linker reported a non-fatal
LNK4098warning. Those builds were not repeated against the new base; the application andbuild-dev.batwere not launched.Reviewer Notes
This is a shared presentation-layer fix; no transport, persisted state, or protocol changes are involved. Browser checks are local style-fixture evidence. Live remote workspace, Remote Connect, Peer Device Mode, and Detached Dispatch scenarios were not exercised.
Checklist