fix(acp): remove automatic rejection from permission settings - #2883
Merged
Conversation
Limit ACP permission choices to ask and auto approve across the settings views. Normalize legacy reject_once values to ask when saving through settings, remove obsolete translations, and cover supported and legacy permission configurations.
wgqqqqq
reviewed
Sep 8, 2026
Track persisted automatic-rejection settings separately from edited values and show a warning with a Save and apply action across ACP settings views. Keep the action available after a failed save and clear it only after successful persistence. Exercise legacy configuration saving, unchanged Ask selection, cross-view actions, and retry behavior with the real Select component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove Auto reject from the shared ACP permission selector so the settings views offer only Ask and Auto approve. Remove its English, Simplified Chinese, and Traditional Chinese labels, and cover supported and legacy permission values in the settings tests.
Type and Areas
Type: UI/UX, bug fix, test
Areas: Web UI, ACP settings, localization
Motivation / Impact
Users can choose whether ACP tool requests require confirmation or are automatically approved. Existing
reject_oncevalues load asaskin the settings editor and are written asaskwhen the user saves; opening settings alone does not rewrite the stored configuration.Verification
After rebasing onto
origin/mainatc88b25fa5:pnpm --dir src/web-ui run test:run src/infrastructure/config/components/AcpAgentsConfig.test.tsx— 20 tests passed.pnpm run check:web— passed.pnpm run i18n:audit— passed with zero warnings.git diff origin/main...HEAD --check— passed.Reviewer Notes
The backend ACP protocol and configuration types retain compatibility with legacy values. No backend data migration is performed. Validation uses the local settings test harness; remote workspace, remote control, Peer Device Mode, and Detached Dispatch were not exercised end to end.
Checklist