feat: add standalone data migrator and workspace resources panel - #2887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ship Data Migrator as a separately versioned offline utility with editable source/destination locations, durable resumable tasks, its own localized UI and theme assets, and independent packaging/signing. Desktop startup, settings, development, and release packaging no longer launch or bundle migration.
Add a persistent workspace resources panel that combines files and terminals while keeping the active conversation or editor open. Terminal ownership follows its creation workspace; opening a saved configuration does not execute it, and closing a regular terminal view detaches without stopping the process.
Type and Areas
Feature, refactor, UI, documentation, and CI. Affects Data Migrator, shared Rust configuration/storage owners, Desktop, Web UI, product definitions, and release workflows.
Motivation / Impact
config-contracts, reusable storage formats into narrowly selectedservices-corefeatures, and offline converters intolegacy-migration-adapters. Core preserves compatibility exports and runtime ownership; the migrator does not depend on Core or Product Assembly. Existing workspace dependency versions are reused.Verification
Passed on Windows:
pnpm run check:web— type-check, appearance, typography, theme color, and visual governance contracts.pnpm run check:core-boundariesandpnpm run check:core-boundaries:test.pnpm run check:github-config,pnpm run check:repo-hygiene, andpnpm run i18n:audit.pnpm run data-migrator:theme:check.node --test --test-concurrency=1 scripts/data-migrator-tauri-build.test.mjs scripts/desktop-tauri-build.test.mjs scripts/product-customization/resolver.test.mjs scripts/product-customization/projections.test.mjs— 32 tests passed.node --checkonscripts/dev.cjs,scripts/data-migrator-release.mjs, and the migrator'sui/app.js,ui/theme.js, andui/transport.js.git diff origin/main...HEAD --checkandnode scripts/check-git-object-sizes.mjs --base origin/main --head HEAD.Exact frontend test command
Additional focused checks passed on Windows:
pnpm run lint:web(no errors), followed by ESLint on the changed runtime files.pnpm --dir src/web-ui exec vitest run --maxWorkers=4 src/infrastructure/design-system/IconUsageIntegration.test.tsx src/app/scenes/browser/BrowserAddressField.presentation.test.ts src/infrastructure/config/components/ModelServiceCollapse.presentation.test.ts src/tools/editor/services/ModelIndentation.test.ts src/app/scenes/workspace-resources/workspaceResources.test.ts src/app/scenes/workspace-resources/terminalViewLifecycle.test.tsx src/tools/terminal/services/terminalWorkspaceScope.test.ts— 37 tests passed.cargo test --locked -p openbitfun-data-migrator -p openbitfun-legacy-migration-adapters -p openbitfun-legacy-migration --lib— 60 tests passed.cargo test --locked -p openbitfun-legacy-migration --test migration_engine_contracts— 9 tests passed.cargo test --locked -p terminal-core --lib workspace_origin_contract_tests— 2 tests passed.cargo test --locked -p openbitfun-config-contracts --lib— 71 tests passed.cargo test --locked -p openbitfun-core --no-default-features --features remote-workspace --lib service::workspace::manager::tests— 2 tests passed. The narrowerworkspace-runtimetest selection could not compile because its filesystem test helpers require the remote workspace module.The full local Web UI run exposed shared-icon regressions, two CRLF-sensitive source tests, and a cold Monaco setup timeout. The affected cases pass after using catalog icons, normalizing test input line endings, and granting only real Monaco initialization a 60-second timeout (measured at about 20 seconds on Windows). Per-test assertion timeouts are unchanged. The full PR CI workflow and Repository Object Sizes check passed on commit
7f805aefed99be41a245f338efd87fe01c83d445. All 14 checks passed, including the full frontend suite, Linux/macOS/Windows Rust and CLI checks, and Linux x64/ARM64 packaging and installer validation.Reviewer Notes
initialCwdresponse enrichment for older hosts. Keeps the latest macOS process-inventory fix and Windows hidden-child-process behavior.Checklist