Skip to content

Fix lights correctly hidden at start #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ClementPasteau merged 1 commit into from
Oct 2, 2026
Merged

Fix lights correctly hidden at start #2279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions extensions/reviewed/Light3D.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"name": "Light3D",
"previewIconUrl": "https://asset-resources.gdevelop.io/public-resources/Icons/f237ae4e3b857c556846c7b2c0b132556fd4bcdeff217034b4d9c97dc1aab1d6_lightbulb-on-outline.svg",
"shortDescription": "A collection of light object for 3D.",
"version": "1.0.4",
"version": "1.0.5",
"description": "A collection of light object for 3D.",
"origin": {
"identifier": "Light3D",
Expand Down Expand Up @@ -598,7 +598,11 @@
" spotLight.castShadow = false;",
" spotLight.visible = false;",
"",
" if (!object.isHidden()) {",
" // Instances hidden at start stay visible in the editor, but their light must not shine.",
" const isHiddenAtStartInEditor =",
" !!editor && !!editor.isInstanceHiddenAtStart && editor.isInstanceHiddenAtStart(object);",
"",
" if (!object.isHidden() && !isHiddenAtStartInEditor) {",
" let isSelected = false;",
" if (editor) {",
" const selectedObject = editor._selection.getLastSelectedObject();",
Expand Down
Loading