feat(cli): expose insert-rate, search-stages, streaming-concurrencies for StreamingPerformanceCase - #5
Open
Saccilotto wants to merge 1 commit into
Open
feat(cli): expose insert-rate, search-stages, streaming-concurrencies for StreamingPerformanceCase#5Saccilotto wants to merge 1 commit into
Saccilotto wants to merge 1 commit into
Conversation
… for StreamingPerformanceCase The CLI accepted --case-type StreamingPerformanceCase but had no way to override its insert_rate, search_stages, or concurrencies knobs, so every run silently used the class defaults (500 rows/s, 0.5/0.8 stages, 5/10 concurrencies). Add --insert-rate, --search-stages, and --streaming-concurrencies options (comma-separated for the two list values, mirroring --num-concurrency) and wire them into get_custom_case_config for StreamingPerformanceCase. Other case types are unaffected.
Collaborator
Author
|
Tracked end-to-end in GRINPROJS-PUCRS/expdb#411 (this repo has Issues disabled). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
--case-type StreamingPerformanceCaseis accepted, butget_custom_case_confighas no branch for it, so
insert_rate,search_stages, andconcurrenciesalways fall back to the class defaults (500 rows/s, [0.5, 0.8], [5, 10]) with
no way to override them from the CLI.
This is what GRINPROJS-PUCRS/expdb#404 needs: the expdb adapter builds a
streaming profile and expects
--insert-rate,--search-stages, and--streaming-concurrenciesto exist on this CLI.Change
--insert-rate INTEGER(default 500)--search-stages TEXT— comma-separated stream-completion fractions, e.g.0.5,0.8--streaming-concurrencies TEXT— comma-separated concurrency levels, e.g.5,10Parsed the same way
--num-concurrencyalready is, and only routed intocustom_case_configwhen--case-type StreamingPerformanceCase; every othercase type is untouched.
Validation
test_streaming_cli.py(new, 4 cases: options exposed, defaults, overrides,ignored for non-streaming case types) and
test_cli_note.pypass.black --check/ruff checkclean on the touched files.