fix: make git cleanliness check look at parent repos to avoid errors when mlops not run from repo root#186
Open
samdporter wants to merge 1 commit into
Open
fix: make git cleanliness check look at parent repos to avoid errors when mlops not run from repo root#186samdporter wants to merge 1 commit into
samdporter wants to merge 1 commit into
Conversation
…when mlops not run from repo root
There was a problem hiding this comment.
Pull request overview
This PR fixes the Git cleanliness check in Experiment.check_dirty() so it works when mlops run is executed from a subdirectory within a Git repository, by allowing GitPython to locate the repository root in parent directories.
Changes:
- Update GitPython
Repo(...)initialization to search parent directories for.git, preventingInvalidGitRepositoryErrorwhen invoked from a daughter directory.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix git check failing when using
mlops runfrom a subdirectory.Issue:
Repo(self.project_path)only inspected exact path, so launching from a daughter directory raisedInvalidGitRepositoryErroreven with a clean tree.Proposed fix:
Adding
search_parent_directories=Trueargument checks whole repo for.git, regardless of the launch directory.