Fix some issues with dimensions#258
Open
FourIsTheNumber wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the Underworld work again. This doesn't fix remapping yet, I haven't decided how I want to do that.
-Add remapping for missing 2 meta values of portals
-
Remove "invulnerability" from NBT data and just make both portals unbreakable from the dimension's side(Reverted)-Fix portal not working by generating the chunks before creating the spawn room
-Remove non-thread-safe block caching, I don't think the coordinates should be cached if you break the block anyways
-Don't try to find the portal twice, this is a very expensive operation
-Remove now-unreachable state where portal is blocked while traveling from overworld to underworld
Checklist
-✅I have tested this PR in DevEnv
-❌ I have tested this PR in Fullpack
-✅ This PR is in compliance with the GTNH AI Policy
-❌ This PR requires another PR in order to merge