[GFX-200] feature/GFX-200

[AlianBlank]

Linear: GFX-200

Summary by CodeRabbit

• 其他
  • 明确标注 MD5 用于非加密场景的校验用途，减少相关静态分析提示。
  • 未改变现有功能或公开接口。

[linear-code]

GFX-200

[coderabbitai]

📝 Walkthrough

Walkthrough

为 Md5Helper 引入代码分析特性，并在公有 MD5 哈希方法上抑制 Sonar S4790 告警，说明该方法用于非加密或校验场景。

Changes

MD5 静态分析告警抑制

Layer / File(s)	Summary
添加 MD5 告警抑制 GameFrameX.Foundation.Hash/Md5Helper.cs	引入 System.Diagnostics.CodeAnalysis，并为 Hash(byte[] input, bool isUpper = false) 添加针对 Sonar S4790 的 SuppressMessage 特性。

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

• GameFrameX/GameFrameX.Foundation#106：同样修改 Md5Helper.cs，引入 System.Diagnostics.CodeAnalysis 并抑制 Sonar S4790 告警。

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	标题仅包含工单号和分支名，未说明本次对 Md5Helper 的实际变更。	请改为能概括核心改动的标题，例如“为 Md5Helper 的 MD5 用法添加弱哈希告警抑制”。

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/GFX-200

---

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@GameFrameX.Foundation.Hash/Md5Helper.cs`:
- Around line 134-135: Update the XML documentation for the public Hash(byte[]
input, bool isUpper = false) method in Md5Helper to explicitly restrict it to
non-cryptographic checksums, fingerprints, and cache keys, and explicitly
prohibit password storage, signatures, and security-sensitive integrity
validation. Keep the existing Sha256Helper guidance and SuppressMessage
unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 679ed0fd-c97d-45bf-b3f5-5bacbd28d602

📥 Commits

Reviewing files that changed from the base of the PR and between 344f6d8 and 390b7ac.

📒 Files selected for processing (1)

• GameFrameX.Foundation.Hash/Md5Helper.cs

[coderabbitai]

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

请明确限制该公开 API 的使用场景。

SuppressMessage 会让整个公开的 Hash(byte[]) 实现不再触发 S4790，但当前 XML 文档没有说明该方法仅适用于校验、指纹或缓存键生成。这样可能掩盖密码存储、签名或安全完整性校验等不安全调用。请在该方法文档中明确禁止安全敏感用途，或提供命名更明确的非加密哈希 API；README.md 已说明这些场景应使用更强算法。

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@GameFrameX.Foundation.Hash/Md5Helper.cs` around lines 134 - 135, Update the
XML documentation for the public Hash(byte[] input, bool isUpper = false) method
in Md5Helper to explicitly restrict it to non-cryptographic checksums,
fingerprints, and cache keys, and explicitly prohibit password storage,
signatures, and security-sensitive integrity validation. Keep the existing
Sha256Helper guidance and SuppressMessage unchanged.