Skip to content

[GFX-204] feature/GFX-204 #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlianBlank wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[GFX-204] feature/GFX-204 #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion GameFrameX.Foundation.Localization/Core/ResourceManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
// Official Documentation: https://gameframex.doc.alianblank.com/
// ==========================================================================================

using System;
using System.Collections.Concurrent;
using System.Globalization;
using System.Threading;
Expand All @@ -52,7 +53,7 @@
/// var message = manager.GetString("Utility.Exceptions.TimestampOutOfRange");
/// </code>
/// </example>
public class ResourceManager
public class ResourceManager : IDisposable

Check warning on line 56 in GameFrameX.Foundation.Localization/Core/ResourceManager.cs

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Fix this implementation of 'IDisposable' to conform to the dispose pattern. 


See more on https://sonarcloud.io/project/issues?id=GameFrameX_GameFrameX.Foundation&issues=AZ-vAEU72NhhPqB0ko9R&open=AZ-vAEU72NhhPqB0ko9R&pullRequest=111
{
private readonly List<IResourceProvider> _providers;
private readonly Lazy<ConcurrentDictionary<string, AssemblyResourceProvider>> _assemblyProviders;
Expand Down