Repository navigation
Conversation
BK1031
commented
Sep 16, 2026
BK1031
commented
- Document the current Mapache architecture and production-readiness gaps
- Propose v4 vehicle, signal, ingestion, query, subscription, and widget contracts
- Define reliability, authorization, operations, migration phases, and open design decisions
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a87d2eba7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 2. Capture a subscription watermark/cursor. | ||
| 3. Execute history through that watermark. | ||
| 4. Buffer log events after the watermark while history runs. |
There was a problem hiding this comment.
When the storage writer is behind the broker, capturing a broker cursor and immediately querying ClickHouse cannot return history "through" that cursor: the proposed observation row stores no broker partition or offset, while the buffer contains only events after the watermark. Pre-watermark records still awaiting persistence therefore appear in neither the snapshot nor the buffer and are silently lost from the subscription. Persist consumer coordinates and wait for the query store to materialize the watermark, or buffer from an earlier boundary, before emitting snapshot completion.
Useful? React with 👍 / 👎.
| platform_id nullable | ||
| vehicle_id nullable | ||
| source_id |
There was a problem hiding this comment.
When multiple vehicles share a platform, every source_id is nevertheless vehicle-scoped by the data-source model, so a binding that requires source_id can belong to only one vehicle and cannot act as the advertised reusable platform-level binding. Creating one copy per vehicle also removes the platform-default/vehicle-override behavior described below. Model a platform source role or binding template separately, then resolve it to each vehicle's concrete source.
Useful? React with 👍 / 👎.
1 participant
