Update output.js to follow style guide on line length#187
Open
math-witch wants to merge 10 commits into
Open
Conversation
…tadata under discussion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Update output.js to follow style guide on line length
about: GenderMag Recorders Assistant project
What does this implementation fix? Explain your changes.
This implementation adheres output.js to the style guideline that the column limit is 80 characters.
Does this close any open issue? (Give issue id from issue tracker)
This partly fixes issue #161 , certain lines are left unwrapped to avoid syntax errors.
Include any related logs, error, output file etc.
No logs, errors, or output files were produced.
Did you test on Mac and Windows?
I did not test on Mac and Windows because I did not add or change any code. My edits are exclusively related to reformatting.
Did you test the full GM process and verify that the code does not contribute any unexpected errors/bugs?
I did not test the full process because I did not add or change any code. My edits are exclusively related to reformatting.
Did you follow the style guidelines and verify that the code does not have any incorrect formatting?
I verified that the lines I did wrap follow the guidelines, some lines are left unwrapped out of caution for syntax errors.
If possible, provide a screenshot of the functionality.
Additions did not change any functionality.
Any other information?
This pull request currently merges on master, against the pull request guidelines for this project. This is because I have been unable to create a branch and cannot find any documentation on requesting the ability to do so. I understand this means this particular pull request will almost certainly be rejected. If/when I am given the permissions to create a new branch, I will happily create a pull request for the same matter on the new branch.