Repository navigation
Ship guides/ in the Hex package; fix the keystore.properties.example reference (MOB-501) - #154
Merged
Merged
Conversation
… reference (MOB-501)
…oogle_play writes (MOB-501)
Owner
Author
|
Review: Codex round 1 said DO NOT SHIP: the packaging fix had no regression test, and the setup-wizard wording was too broad. Both are fixed: ToolchainPackageTest now fails if guides/ is left out. Round 2: SHIP, no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MOB-501, found while verifying the mob_new 0.6.16 release on a phone.
deps/mob_dev/guides/.package/0now listsfiles:(the defaults plusguides/, 140 KB). Checked withmix hex.build --unpack.mix mob.release(Android prerequisites) and guides/publishing_to_google_play.md said to copyandroid/keystore.properties.example, which no generated app has. Both now list the four keys and namemix mob.setup.google_play, which writes the file.remove_stale_host_ssl/1describe label claimed coverage of the iOS-sim and copy_app_beams wiring; the label now says only the helper is tested.Checks: 3176/3176, credo and format clean.