Code PyGMT logo in PyGMT#3849
Conversation
|
/format |
|
I feel the logo definition should be separated into a standalone method, similar to the method to plot the GMT logo. This would allow to plot the PyGMT logo by calling something like |
|
ruff v0.10.0 was released 2 hours ago causing the newly falling code style checks. |
@yvonnefroehlich You can follow the steps below:
Then, you should be able to call |
Seems like this helped. Thanks! |
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Sounds good! BTW there is also the layered-animation branch which was used to create animations to show the plotting order of the single elements of the logo. |
|
As this PR has a very long comment and commit history, and it's difficult to quickly find a specific comment or discussion, we plan to merge this PR first and start follow-up PRs to work on open aspects. Some aspects are already (partly) addressed, and the list is probably not complete:
|
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
| outs: | ||
| - md5: 35c59c31c92f13c705a24933465ff551 | ||
| size: 14374 | ||
| isexec: true |
There was a problem hiding this comment.
This line says that the pygmt/tests/baseline/test_pygmtlogo.png file has execution permission. Could you please remove the execution permission and add it agagin?
Description of proposed changes
Related to #1404 (comment), create the PyGMT logo in Python with PyGMT:
Figure.pygmtlogoorFigure.logo_pygmtas part of theFigureclass oraddition to the method
Figure.logo(which plots the GMT logo)Gallery example-> separate PRRelated to
Preview:
https://pygmt-dev--3849.org.readthedocs.build/en/3849/api/generated/pygmt.Figure.pygmtlogo.html
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code