ci(windows): run hidden-process contract tests on PRs and main

[danielgap]

Enables the Windows hidden-process contract test workflow for pull requests and main.

The code fix this PR originally carried — the 21 windowsHide: true callsite additions and tests/windows-hidden-processes.test.ts — already landed on main in e50b43d (#967). After rebasing onto current main, the net change here is the workflow enablement only:

• run on push to main (was the feature branch)
• run on pull_request targeting main
• drop the decode2/gentle-pi repository gate

Rebased into a single commit and retitled per review feedback. References #967.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 34009c47-c196-410f-8f44-484f42770a02

📥 Commits

Reviewing files that changed from the base of the PR and between 94ecee5 and 2096846.

📒 Files selected for processing (1)

• tests/windows-hidden-processes.test.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

---

📝 Walkthrough

Walkthrough

The change adds windowsHide: true to internal Git, GitHub CLI, and CodeGraph launches. New contract tests capture these routes and preserve the external-editor exception. A GitHub Actions workflow runs the tests on Ubuntu and Windows.

Changes

Windows hidden-process coverage

Layer / File(s)	Summary
Internal launch option propagation extensions/codegraph-tools.ts, extensions/gentle-ai.ts, lib/review-*.ts	Internal Git, GitHub CLI, and CodeGraph child-process invocations now pass windowsHide: true.
Child-process contract tests tests/windows-hidden-processes.test.ts	Capturing fakes trace twelve public actions and verify hidden-process options. The external editor remains configured with inherited stdio and no windowsHide option.
Cross-platform workflow .github/workflows/windows-hidden-processes.yml	The new workflow runs the contract tests on ubuntu-24.04 and windows-latest with pinned Node and pnpm versions.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: alan-thegentleman

Merge Risk: ⚪ Minimal · up to 20968

The audited internal launches now set Windows process hiding, with cross-platform contract coverage and no concrete merge-blocking defect identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 23 functions across 7 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Issue #967 requires windowsHide: true at 21 audited internal, noninteractive launch callsites across six files. The PR adds the option to the listed CodeGraph, review identity, Git, and gh launche…
Out of Scope Changes check	✅ Passed	The source changes stay within issue #967. The contract tests and dual-OS workflow support the required launch-option validation. The changes do not add unrelated launch families or alter arguments, e…
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the new Windows hidden-process contract workflow, which is a real part of the pull request. It does not mention the primary code change that adds windowsHide: true to in…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[danielgap]

The first CI run failed on two pre-existing or unrelated causes, both addressed or scoped:

1. Type check (fixed): the new test file's inline win32 spread widened its element type and tripped the recorded-diagnostics ratchet (TS2322 against ExpectedCall, 201 vs 200). 2096846d extracts the fallback into a typed ExpectedCall[] constant: ratchet back to 200 with no regressions, contract tests still 2/2, full suite 0 failures. This head went through its own full four-lens native review (approved, zero corrections).

2. review-repository-windows (pre-existing): candidate view owner preparation failed is the documented ci(windows): candidate owner preparation fails when a PowerShell spawn exceeds its 5 s timeout #990 PowerShell spawn-timeout failure on cold Windows runners, already fixed by open PR fix(review): bound Windows owner command duration #1009. It is unrelated to this change; this PR's own Windows validation runs through the ported test (windows-latest) leg, which passed (43s) alongside its Ubuntu twin.

[danielgap]

Rebased onto current main (d8abc81). The situation changed since this PR opened: the fix itself and the contract tests are already on main (windowsHide across gentle-ai.ts, the lib/review-* files, and codegraph-tools.ts, plus tests/windows-hidden-processes.test.ts via 7d5b58e and f2bb223).

What this PR now carries is the one piece main is missing: the workflow trigger. Main's copy of windows-hidden-processes.yml only runs on the fix/windows-hidden-internal-processes branch with a fork guard, so the contract tests never execute on PRs to the canonical repo. After the rebase this is a single 6-line change restoring push: main + pull_request: main, and the effect is visible on this PR itself: test (windows-latest) and test (ubuntu-24.04) now run and pass here.

If you'd rather keep Windows runners off every PR, closing this in favor of a maintainer-side trigger tweak works too; otherwise this is ready to merge as-is.

[decode2]

Thanks for driving this forward @danielgap!

One important catch before merging: the actual code fix (the 21 windowsHide: true callsite additions) and tests/windows-hidden-processes.test.ts were already merged into main in e50b43d7. Because of that, the net diff against main here is strictly the 23-line CI workflow enablement in .github/workflows/windows-hidden-processes.yml.

To keep git history clean and prevent changelog misattribution:

1. Please rebase this branch onto current main (which will cleanly drop the duplicate commits and the temporary tmp-push-1027 merge commit).
2. Retitle the commit/PR as ci(windows): run hidden-process contract tests on PRs and main (linking bug(windows): hide remaining internal CodeGraph and review process launches #967 in the description).

Once rebased with that commit scope, this is good to go!

[danielgap]

Done: rebased onto current main as a single commit (078ba2e) and retitled to ci(windows): run hidden-process contract tests on PRs and main, with #967 referenced in the description.

The duplicate commits and the tmp-push-1027 merge are gone, so the net diff is now only the workflow enablement (push to main, pull_request targeting main, repository gate dropped).

Thanks for catching the e50b43d overlap. Nothing else pending on my side.