Skip to content

Update aws versions, remove deprecated methods - #211

Merged
sue-h-gns merged 2 commits into
mainfrom
updateAWSVersionsAndDeprecatedMethods
Aug 5, 2026
Merged

Update aws versions, remove deprecated methods#211
sue-h-gns merged 2 commits into
mainfrom
updateAWSVersionsAndDeprecatedMethods

Conversation

@CallumNZ

@CallumNZ CallumNZ commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

Changes proposed in this pull request:

  • Bump versions of some dependencies, including some AWS SDK services, to resolve govuln errors.
  • Remove AWS SDK custom endpoint resolver methods, to resolve golint errors. No longer needed to work with Localstack.

Notes:

I'm not sure if bit I've removed from the Keyspaces getConfig() function was doing anything, as the replacement is tied to the Keyspaces Client, which we don't use.

I haven't tried it with a real application yet (i.e.: not Localstack).

I ran go get golang.org/x/text and go get github.com/aws/aws-sdk-go-v2/service/s3 , which has bumped go.mod go version to 1.25.0. I assume this is valid and not go get being annoying.

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

@CallumNZ
CallumNZ requested a review from wilsonjord August 5, 2026 04:41
@CallumNZ
CallumNZ force-pushed the updateAWSVersionsAndDeprecatedMethods branch from 906be49 to 9709709 Compare August 5, 2026 21:08
@CallumNZ CallumNZ changed the title Update aws versions and deprecated methods Update aws versions, remove deprecated methods Aug 5, 2026

@wilsonjord wilsonjord left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tidy

@sue-h-gns
sue-h-gns merged commit 96858a8 into main Aug 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants