Skip to content

fix(GidOutput): check if material_attribute exist in is saveable - #204

Merged
BotellaA merged 1 commit into
nextfrom
fix/check_for_material_attribute
Aug 19, 2026
Merged

fix(GidOutput): check if material_attribute exist in is saveable#204
BotellaA merged 1 commit into
nextfrom
fix/check_for_material_attribute

Conversation

@BenPinet

Copy link
Copy Markdown
Member

No description provided.

@github-actions

Copy link
Copy Markdown

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v21.1.8) reports: 2 concern(s)
  • src/geode/io/model/gid_output.cpp:64:34: warning: [bugprone-unchecked-optional-access]

    unchecked access to optional value

       64 |                                  attribute_ids.value().at( 0 ) );
          |                                  ^~~~~~~~~~~~~
  • src/geode/io/model/gid_output.cpp:81:34: warning: [bugprone-unchecked-optional-access]

    unchecked access to optional value

       81 |                                  attribute_ids.value().at( 0 ) );
          |                                  ^~~~~~~~~~~~~

Have any feedback or feature suggestions? Share it here.

@BotellaA
BotellaA merged commit 0d30ff5 into next Aug 19, 2026
23 checks passed
@BotellaA
BotellaA deleted the fix/check_for_material_attribute branch August 19, 2026 15:53
@BotellaA

Copy link
Copy Markdown
Member

🎉 This PR is included in version 7.8.1-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA

Copy link
Copy Markdown
Member

🎉 This PR is included in version 7.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants