Skip to content

feat(Attribute): attribute filtering on import - #1278

Closed
BotellaA wants to merge 1 commit into
nextfrom
fix/import-filter-attribues
Closed

feat(Attribute): attribute filtering on import#1278
BotellaA wants to merge 1 commit into
nextfrom
fix/import-filter-attribues

Conversation

@BotellaA

Copy link
Copy Markdown
Member

cc @yo35

@BotellaA
BotellaA requested a review from panquez May 29, 2026 06:56
@github-actions

Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 2 concern(s)
  • src/geode/basic/attribute_manager.cpp:328:32: warning: [bugprone-easily-swappable-parameters]

    2 adjacent parameters of 'rename_attribute' of similar type ('std::string_view') are easily swapped by mistake

      328 |         void rename_attribute( std::string_view old_name,
          |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~
      329 |             std::string_view new_name,
          |             ~~~~~~~~~~~~~~~~~~~~~~~~~
    /__w/OpenGeode/OpenGeode/src/geode/basic/attribute_manager.cpp:328:49: note: the first parameter in the range is 'old_name'
      328 |         void rename_attribute( std::string_view old_name,
          |                                                 ^~~~~~~~
    /__w/OpenGeode/OpenGeode/src/geode/basic/attribute_manager.cpp:329:30: note: the last parameter in the range is 'new_name'
      329 |             std::string_view new_name,
          |                              ^~~~~~~~
  • src/geode/basic/attribute_manager.cpp:412:9: warning: [readability-avoid-return-with-void-value]

    return statement within a void function should not have a specified return value

      412 |         return impl_->register_attribute( attribute, name, {} );
          |         ^~~~~~

Have any feedback or feature suggestions? Share it here.

@yo35

yo35 commented May 29, 2026

Copy link
Copy Markdown
Contributor

@BotellaA @panquez As I said in #1277, maybe I can propose a solution more simple, by overloading methods import(..) with a additional std::string_view attribute_name argument, to allow importing attributes one by one. I think it would lead to a simpler API.

@BotellaA

Copy link
Copy Markdown
Member Author

@yo35 propose your second idea and we will see which one looks simpler. Probably the second one

@yo35

yo35 commented May 29, 2026

Copy link
Copy Markdown
Contributor

Alternative solution proposed in #1279

@BotellaA BotellaA closed this Jun 2, 2026
@BotellaA
BotellaA deleted the fix/import-filter-attribues branch June 2, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants