fix: iOS boolean conversion never parsed false - #59
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesBoolean constraint conversion
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
oliverlaz
approved these changes
Aug 5, 2026
|
🎉 This PR is included in version 145.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gabrieldonadel
pushed a commit
to gabrieldonadel/GetStream-react-native-webrtc
that referenced
this pull request
Sep 5, 2026
…am#59) * Move media projection fgs to WebRTCForegroundService * Remove file uploaded by mistake * Fixes outlined by copilot + format * Fix format * Format * Report incoming call on the JS side * Handle VoIP push token registration * Remove manually calling myself form code and add some logs for dev purposes * Simplify message passing between objects with callbacks instead of notification center * Add PushKit category * Add useVoIPEvents hook * Change queue to a serial one * Synchronously get voip token on mount * format * lint * Fix typo and remove obsolete code * format * Rename * lint * Change naming again lol * Minor renaming * Add some default values and enforce roomName * Fix race condition scenario with sending payload and answering the call * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Always report incoming calls --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
"true"or"false", ensuring non-boolean inputs are interpreted based on their actual boolean value.