Repository navigation
Fix notification suppression for cached and visible cards - #192
Merged
Merged
Conversation
boehlerlukas
marked this pull request as ready for review
October 22, 2026 17:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signup already calls
setDisableInAppNotifications(true), but the SDK only checks that flag when outbound actions arrive. Cached announcements can still appear, and cards already on screen remain visible after the setting changes.Honor the flag when rendering notification cards and playing notification sounds, and refresh the cards immediately when the setting changes. Cached cards remain available when notifications are enabled again and still respect page exclusions. The support launcher and messenger remain available.
Validation: reproduced three failures before the fix; all 34 test suites / 586 tests pass afterward, including five regression cases covering startup/cache reload, immediate suppression, silent direct delivery, page exclusions, and opening support chat.
npm run buildpasses with bundle-size warnings.This PR contains the SDK fix only. The dashboard will need to consume a release containing it for the signup change to be live.