Repository navigation
feat: GleapBannerArea keeps the app below inline banners - #66
Merged
Merged
Conversation
Forwards the native bannerHeightChanged event, adds Gleap.getBannerHeight() (read on load and on initialized, since the native SDKs only report changes), useGleapBannerHeight() and GleapBannerArea, which pads its children down by the banner's height (animated). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React Native counterpart of GleapSDK/Flutter-SDK#46 (customer: Operátor ICT, ticket 129428). Uses the native API from GleapSDK/Gleap-iOS-SDK#58 and GleapSDK/Android-SDK#53.
bannerHeightChanged(iOS delegate / Android callback) and exportgetBannerHeight().src/bannerHeight.tsholds the current height, read on load and oninitializedbecause the native SDKs only report changes (JS reload).useGleapBannerHeight()hook,GleapBannerArea(animatedpaddingTop, 250 ms),registerListener('bannerHeightChanged', …)also fires.GleapBannerAreakeep the overlay behaviour. README documents the safe-area-context adjustment (the banner already covers the status bar).Verified
clang -fsyntax-onlyagainst the new Gleap headers + RN 0.85 headers, 0 errors.javacagainst the new AAR (local 19.2.4 + this feature) and react-android 0.87, 0 errors.bob buildOK; a scratch jest run covered initial getter, events, duplicate suppression and JS-reload recovery.Compiles against the published SDKs only after the 19.3.0 native release; the release bump updates the pins.
🤖 Generated with Claude Code