Skip to content

fix: harden fix-issue workflow#46

Open
web3-jeff wants to merge 1 commit intomainfrom
codex-fix-issue-workflow-safety
Open

fix: harden fix-issue workflow#46
web3-jeff wants to merge 1 commit intomainfrom
codex-fix-issue-workflow-safety

Conversation

@web3-jeff
Copy link
Copy Markdown
Collaborator

Summary

Brief description of the changes.

Type

  • Bug fix
  • New feature / detection rule
  • Refactoring
  • Documentation

Testing

  • npm run build passes
  • npm test passes (32 tests)
  • Manually tested the change

Related Issues

Closes #

@github-actions
Copy link
Copy Markdown

AgentGuard PR Review

I found one actionable issue introduced by this workflow change.

  1. medium — .github/workflows/fix-issue.yml (commit step / output handling)
    • What can go wrong: The new Create branch and commit step can exit early on the “No eligible changes generated.” path without ever writing created=false if any command before that fails under set -euo pipefail, and the subsequent PR step is gated on steps.commit.outputs.created == 'true'. This can leave the job in an unexpected state or skip PR creation even when the workflow should report a clean no-op. More importantly, steps.commit.outputs.created is only set on the successful push path, so failure modes are now harder to distinguish and may cause silent workflow behavior changes.
    • Concrete fix: Ensure the created output is always written in every exit path of the step, including failures/no-op branches, e.g. set a default created=false at the start and update it only after a successful push, or split no-op detection into a separate step so the PR-creation condition is deterministic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants