Skip to content

fixed msvc compile build inorder to prevent vendor compile their own utf-8 #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GooberRF merged 6 commits into from
Aug 13, 2026
Merged

fixed msvc compile build inorder to prevent vendor compile their own utf-8 #417

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5020b7f
fixed msvc compile build to prevent SDL3 cmake build to fail
AL2009man Aug 10, 2026
0a08609
Merge branch 'master' into CMake-SDL3-compile-fix
AL2009man Aug 11, 2026
b5def1a
move global charset handlingly to avoid vendor conflicts
AL2009man Aug 11, 2026
50c4470
reduce bloated notes, just to be more straight forward
AL2009man Aug 11, 2026
1d7887d
Revert "reduce bloated notes, just to be more straight forward"
AL2009man Aug 11, 2026
fecce1e
Merge branch 'master' into CMake-SDL3-compile-fix
GooberRF Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,10 @@ set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)
if(MSVC)
add_compile_definitions(_CRT_SECURE_NO_WARNINGS)
add_compile_options(/arch:SSE2)
# Pin both charsets. Sources are UTF-8; narrow string literals are Windows-1252,
# because the .vf bitmap fonts are indexed by Windows-1252 byte value and several
# literals embed those bytes directly (\x95 bullet, \xA6 chat prefix, ...).
# Without this the ordinary literal encoding follows the build machine's system
# code page: on a DBCS locale such as 932 those bytes become invalid multi-byte
# sequences and std::format throws std::format_error at runtime.
add_compile_options(/source-charset:utf-8 /execution-charset:windows-1252)
# Statically link Microsoft's CRT.
set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
else()
add_compile_options(-msse2)
add_compile_options(-finput-charset=UTF-8 -fexec-charset=WINDOWS-1252)
endif()

# Macros
Expand Down Expand Up @@ -81,6 +73,19 @@ macro(setup_debug_info target)
endmacro()

add_subdirectory(vendor)

# Pin both charsets for Alpine Faction's own code. Sources are UTF-8; narrow string literals are Windows-1252,
# because the .vf bitmap fonts are indexed by Windows-1252 byte value and several literals embed those bytes
# directly (\x95 bullet, \xA6 chat prefix, ...). Without this the ordinary literal encoding follows the build
# machine's system code page: on a DBCS locale such as 932 those bytes become invalid multi-byte sequences and
# std::format throws std::format_error at runtime.
# This is applied AFTER vendor/ so third-party code keeps its own charset settings.
if(MSVC)
add_compile_options(/source-charset:utf-8 /execution-charset:windows-1252)
else()
add_compile_options(-finput-charset=UTF-8 -fexec-charset=WINDOWS-1252)
endif()

add_subdirectory(launcher_common)
add_subdirectory(launcher)
add_subdirectory(common)
Expand Down
Loading