feat: add service overrides state to build response#203
Merged
Conversation
bc96484 to
085c17c
Compare
levontikoyan
approved these changes
May 12, 2026
085c17c to
b32707e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/v2/builds/{uuid}by annotating each returneddeploys[]item withserviceOverride.GET /api/v2/builds/{uuid}/servicesoperation because the UI can now build the edit form from the existing build detail response.PATCH /api/v2/builds/{uuid}/servicesas the targeted mutation endpoint and aligns the request field name toname.API Shape
GET build request
GET build response excerpt
{ "data": { "uuid": "demo-build-123456", "deploys": [ { "uuid": "api-demo-build-123456", "status": "deployed", "statusMessage": null, "active": true, "branchName": "feature/api", "publicUrl": "https://api-demo.example.test", "updatedAt": "2026-05-08T12:00:00.000Z", "deployable": { "name": "api", "type": "github" }, "serviceOverride": { "name": "api", "branchOrExternalUrl": "feature/api", "group": "default", "editable": true } }, { "uuid": "api-cache-demo-build-123456", "status": "pending", "statusMessage": null, "active": true, "deployable": { "name": "api-cache", "type": "github" }, "serviceOverride": null } ] } }PATCH services request
{ "serviceOverrides": [ { "name": "api", "active": false, "branchOrExternalUrl": "feature/api" } ] }PATCH services response
{ "data": { "serviceOverrides": [ { "name": "api", "active": false, "branchOrExternalUrl": "feature/api", "status": "pending", "statusMessage": null, "updatedAt": "2026-05-08T12:05:00.000Z", "group": "default", "editable": true } ], "queued": true } }Implementation Notes
deploy.serviceOverrideis nullable.nullmeans the deploy is still part of the build response, but should not render as an editable service override row.name,branchOrExternalUrl,group, andeditable.active,status,statusMessage,updatedAt,branchName, andpublicUrl.branchOrExternalUrl, but changed display-only values return400.Validation
pnpm test -- src/server/services/__tests__/build.test.ts src/server/services/__tests__/override.test.ts src/shared/openApiSpec.test.tspnpm run lintgit diff --checkpnpm run ts-checkstill fails on existing repo-wide TypeScript issues outside this change.