feat: add universe domain support for TPC - #557
Open
tianwarren123 wants to merge 5 commits into
Open
Conversation
tianwarren123
force-pushed
the
feat/universe-domain-support
branch
from
August 7, 2026 23:32
1bf866b to
95e4a06
Compare
tianwarren123
enabled auto-merge (squash)
August 7, 2026 23:32
tianwarren123
force-pushed
the
feat/universe-domain-support
branch
from
August 7, 2026 23:36
95e4a06 to
89a4756
Compare
Add universe_domain parameter to Connector and AsyncConnector classes to support TPC (Trusted Partner Cloud) universe domains. Changes include: - Dynamic AlloyDB API endpoint construction based on universe domain - GOOGLE_CLOUD_UNIVERSE_DOMAIN env var fallback - Credential universe domain validation - Unit tests for all new functionality
tianwarren123
force-pushed
the
feat/universe-domain-support
branch
from
August 7, 2026 23:41
89a4756 to
fa3efef
Compare
enocom
reviewed
Sep 9, 2026
enocom
left a comment
enocom
left a comment
Member
There was a problem hiding this comment.
LGTM. I'll leave it to Rishabh to approve.
| if universe_domain: | ||
| self._universe_domain: Optional[str] = universe_domain | ||
| else: | ||
| self._universe_domain = os.environ.get("GOOGLE_CLOUD_UNIVERSE_DOMAIN") |
Member
There was a problem hiding this comment.
I know Cloud SQL did this. I don't know why other than cover for a shortcoming in the auth library.
I think we should leave out this env var. We provide an API and callers may use it. If there's some standard we're missing, we can add it later. But if we add it now, it's ours forever.
Ditto below.
| "alloydb.googleapis.com", "test-project", credentials, driver="pg8000" | ||
| ) | ||
| transport = connector._client._client.transport | ||
| transport._wrapped_methods[transport.get_connection_info]._retry = Retry( |
Collaborator
There was a problem hiding this comment.
Why is this get_connection_info wrapper being deleted? Also, there's already a wrapper for generate_client_certificate defined below. So we don't need to add it again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add universe_domain parameter to Connector and AsyncConnector classes to support TPC (Trusted Partner Cloud) universe domains. Changes include: