Skip to content

fix: semver sorting for kernel packages - #52

Open
barabo wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
barabo:fix-debian-version-parser
Open

fix: semver sorting for kernel packages#52
barabo wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
barabo:fix-debian-version-parser

Conversation

@barabo

@barabo barabo commented Aug 31, 2026

Copy link
Copy Markdown

The current Debian installer does not sort kernel version numbers using semver, so when the headers version jumped from 96 to 105 - the wrong version is selected.

This change creates a comparator that respects both ABI and kernel version numbers numerically.

@barabo
barabo requested a review from m-strzelczyk as a code owner August 31, 2026 18:05
@barabo

barabo commented Aug 31, 2026

Copy link
Copy Markdown
Author

See #53

@barabo

barabo commented Aug 31, 2026

Copy link
Copy Markdown
Author

You might also consider letting apt decide which kernel versions to use with something like:

self.run("apt-get install -y make gcc linux-image-cloud-amd64 "
         "linux-headers-cloud-amd64 pciutils gcc make dkms cmake git")

I'm assuming there's a good reason for parsing version numbers explicitly, but it might be better to let apt do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant