Repository navigation
test(mdcode): expect the translated metric as a BIGQUERY dialect entry in the two-phase transpile test - #562
Merged
Merged
Conversation
…y in the two-phase transpile test --transpile now writes its translation as a BIGQUERY dialect entry, while the two-phase deploy test still checked the metric's expression. The two changes passed separately, so main failed this test. The check now expects a BIGQUERY entry in the metric's dialects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--transpilenow writes its translation as aBIGQUERYdialect entry, while the two-phase deploy test still checked the metric'sexpression. The two changes passed separately, so main fails this test. The check now expects aBIGQUERYentry in the metric's dialects.