Skip to content

backupdr: fix restore resource_manager_tags drop#18080

Open
Megha-Bose wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
Megha-Bose:fix/backupdr-allfields-tests
Open

backupdr: fix restore resource_manager_tags drop#18080
Megha-Bose wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
Megha-Bose:fix/backupdr-allfields-tests

Conversation

@Megha-Bose

@Megha-Bose Megha-Bose commented Jun 25, 2026

Copy link
Copy Markdown
Contributor
backupdr: fixed issue where `google_backup_dr_restore_workload` dropped `resource_manager_tags` during restore requests, causing tags shown in plan to not be applied to restored resources

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 25, 2026
@github-actions github-actions Bot requested a review from roaks3 June 25, 2026 06:45
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@Megha-Bose Megha-Bose changed the title backupdr: fix restore resource_manager_tags handling and consolidate … backupdr: fix restore resource_manager_tags drop and add multi-tag acceptance coverage Jun 25, 2026
@Megha-Bose Megha-Bose force-pushed the fix/backupdr-allfields-tests branch 6 times, most recently from 4968e61 to 046431a Compare June 26, 2026 13:34
@Megha-Bose Megha-Bose force-pushed the fix/backupdr-allfields-tests branch from 046431a to 3d59a37 Compare June 26, 2026 13:36
@Megha-Bose Megha-Bose changed the title backupdr: fix restore resource_manager_tags drop and add multi-tag acceptance coverage backupdr: fix restore resource_manager_tags drop Jun 26, 2026
@Megha-Bose

Copy link
Copy Markdown
Contributor Author

Adding manual test run logs here as the restore tests could not be added in the CI pipeline. See #16080 for context:

terraform-restore-regional-disk.log
terraform-restore-vm-props.log

@github-actions

Copy link
Copy Markdown

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@roaks3 roaks3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems good. Is there a reason we need to support each of Map, Set, and List? Why are labels implementing all of these? It might make sense to rename processLabels if it is no longer being used just for label fields?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants