feat: (storage) deprecated cache value#18083
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 383351d: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @gurusai-voleti, @roaks3, @kautikdk VCR tests complete for 383351d! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4ff0e36: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @gurusai-voleti, @roaks3, @kautikdk VCR tests complete for 4ff0e36! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8b2da77: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @gurusai-voleti, @roaks3, @kautikdk VCR tests complete for 8b2da77! |
|
@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
roaks3
left a comment
There was a problem hiding this comment.
I had a question about the expander. The deprecation_message is also normally intended for deprecating the whole field, but I suppose it works fine here, maybe worth a comment so someone doesn't accidentally remove the whole field some day.
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ -}} | ||
| func expand{{$.GetPrefix}}{{$.TitlelizeProperty}}(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) { |
There was a problem hiding this comment.
The diff suppress ignores admit-on-second-miss, but the expander here is a bit different and seems to effectively change the user's config to admit-on-first-miss.
Do we need the expander? Perhaps we should message this differently as a change that is being made to their infra?
There was a problem hiding this comment.
seems expander is not needed even user send admin-onsecond-miss backend respond with first-miss and diff is suppressed in diffsuppress, will delete this
…admission_policy.go.tmpl
this entire resource is soon deprecated and a this service is rebranding I will soon raise another PR for it |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8262952: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @gurusai-voleti, @roaks3, @kautikdk VCR tests complete for 8262952! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 43077dc: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @gurusai-voleti, @roaks3, @kautikdk VCR tests complete for 43077dc! |
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.