Skip to content

feat: (storage) deprecated cache value#18083

Open
gurusai-voleti wants to merge 7 commits into
GoogleCloudPlatform:mainfrom
gurusai-voleti:remove_cache_value
Open

feat: (storage) deprecated cache value#18083
gurusai-voleti wants to merge 7 commits into
GoogleCloudPlatform:mainfrom
gurusai-voleti:remove_cache_value

Conversation

@gurusai-voleti

@gurusai-voleti gurusai-voleti commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

storage: depercated `admin-on-second-miss` in `google_storage_anywhere_cache`

@github-actions github-actions Bot requested a review from roaks3 June 25, 2026 08:57
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 383351d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 30 insertions(+), 7 deletions(-)
google-beta provider View Diff 2 files changed, 30 insertions(+), 7 deletions(-)
terraform-google-conversion View Diff 1 file changed, 18 insertions(+), 1 deletion(-)

Test report

Analytics

Total Tests Passed Skipped Affected
136 124 11 1
Affected Service Packages
  • storage

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccStorageAnywhereCache_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccStorageAnywhereCache_update

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@gurusai-voleti, @roaks3, @kautikdk VCR tests complete for 383351d!

@modular-magician

modular-magician commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4ff0e36:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 30 insertions(+), 7 deletions(-)
google-beta provider View Diff 2 files changed, 30 insertions(+), 7 deletions(-)
terraform-google-conversion View Diff 1 file changed, 18 insertions(+), 1 deletion(-)

Test report

Analytics

Total Tests Passed Skipped Affected
136 124 11 1
Affected Service Packages
  • storage

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccStorageAnywhereCache_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccStorageAnywhereCache_update

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@gurusai-voleti, @roaks3, @kautikdk VCR tests complete for 4ff0e36!

@gurusai-voleti gurusai-voleti changed the title Remove cache value feat: (storage) remove cache value Jun 25, 2026
@gurusai-voleti gurusai-voleti changed the title feat: (storage) remove cache value feat: (storage) deprecated cache value Jun 29, 2026
@modular-magician

modular-magician commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8b2da77:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 33 insertions(+), 7 deletions(-)
google-beta provider View Diff 3 files changed, 33 insertions(+), 7 deletions(-)
terraform-google-conversion View Diff 1 file changed, 18 insertions(+), 1 deletion(-)

Test report

Analytics

Total Tests Passed Skipped Affected
136 125 11 0
Affected Service Packages
  • storage

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@gurusai-voleti, @roaks3, @kautikdk VCR tests complete for 8b2da77!

@github-actions

Copy link
Copy Markdown

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@roaks3 roaks3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a question about the expander. The deprecation_message is also normally intended for deprecating the whole field, but I suppose it works fine here, maybe worth a comment so someone doesn't accidentally remove the whole field some day.

See the License for the specific language governing permissions and
limitations under the License.
*/ -}}
func expand{{$.GetPrefix}}{{$.TitlelizeProperty}}(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff suppress ignores admit-on-second-miss, but the expander here is a bit different and seems to effectively change the user's config to admit-on-first-miss.

Do we need the expander? Perhaps we should message this differently as a change that is being made to their infra?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems expander is not needed even user send admin-onsecond-miss backend respond with first-miss and diff is suppressed in diffsuppress, will delete this

@github-actions github-actions Bot requested a review from roaks3 July 1, 2026 05:14
@gurusai-voleti

Copy link
Copy Markdown
Contributor Author

I had a question about the expander. The deprecation_message is also normally intended for deprecating the whole field, but I suppose it works fine here, maybe worth a comment so someone doesn't accidentally remove the whole field some day.

this entire resource is soon deprecated and a this service is rebranding I will soon raise another PR for it

@modular-magician

modular-magician commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8262952:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 25 insertions(+), 6 deletions(-)
google-beta provider View Diff 3 files changed, 25 insertions(+), 6 deletions(-)
terraform-google-conversion View Diff 1 file changed, 10 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
136 125 11 0
Affected Service Packages
  • storage

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@gurusai-voleti, @roaks3, @kautikdk VCR tests complete for 8262952!

@modular-magician

modular-magician commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 43077dc:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 25 insertions(+), 6 deletions(-)
google-beta provider View Diff 3 files changed, 25 insertions(+), 6 deletions(-)
terraform-google-conversion View Diff 1 file changed, 10 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
136 125 11 0
Affected Service Packages
  • storage

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@gurusai-voleti, @roaks3, @kautikdk VCR tests complete for 43077dc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants