Skip to content

Revert "feat(vertexai): add google_vertex_ai_online_evaluator resource"#18084

Open
guvenenb wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
guvenenb:revert-17944-online_evals
Open

Revert "feat(vertexai): add google_vertex_ai_online_evaluator resource"#18084
guvenenb wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
guvenenb:revert-17944-online_evals

Conversation

@guvenenb

@guvenenb guvenenb commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Release Note

Revert "feat(vertexai): add google_vertex_ai_online_evaluator resource"

This reverts the changes introduced in #17944.

Supersedes #18038

The `google_vertex_ai_online_evaluator` resource has been reverted.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 25, 2026
@github-actions github-actions Bot requested a review from rileykarson June 25, 2026 10:42
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

if [ "${{ github.event_name }}" == "pull_request" ]; then
# For PRs, get only changed files
yamlfiles=$(git diff --name-only origin/${GITHUB_BASE_REF} -- mmv1/products)
yamlfiles=$(git diff --name-only --diff-filter=d origin/${GITHUB_BASE_REF} -- mmv1/products)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this change to pass the CI. Otherwise it is giving some error b because the YAML linter tries to lint the deleted file and fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants