Update ManagedZone.yaml to contain ransom suffix for dns_name#18086
Update ManagedZone.yaml to contain ransom suffix for dns_name#18086shellyvilenko wants to merge 1 commit into
Conversation
he Terraform configuration in these tests used a hardcoded dns_name domain name ("m-z.gcp.tfacc.hashicorptest.com."). When these tests run in parallel (or concurrently within the same testing project), multiple test executions attempt to create a Cloud DNS managed zone with the exact same domain name.
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cf089e6: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @shellyvilenko, @SirGitsalot VCR tests complete for cf089e6! |
|
@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
The Terraform configuration in these tests used a hardcoded dns_name domain name ("m-z.gcp.tfacc.hashicorptest.com."). When these tests run in parallel (or concurrently within the same testing project), multiple test executions attempt to create a Cloud DNS managed zone with the exact same domain name.
This PR fixes the flakiness and parallel collision failures in the
google_dns_managed_zoneIAM and quickstart example tests.Problem
When tests run in parallel, multiple test executions attempt to create a Cloud DNS managed zone with the exact same hardcoded domain name (
"m-z.gcp.tfacc.hashicorptest.com."). Since DNS zone domain names must be globally unique within the project/nameservers, this results in collisions andmanagedZoneDnsNameNotAvailableAPI errors.Solution
Updated the
dns_managed_zone_quickstartsample'stest_vars_overridesinmmv1/products/dns/ManagedZone.yamlto dynamically appendrandomSuffixto thedns_name(i.e.,"m-z-" + randomSuffix + ".gcp.tfacc.hashicorptest.com."). This guarantees a unique domain name for every concurrent test invocation.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.