Skip to content

Added new resources for "RegionNetworkPolicyTrafficClassificationRule" #18087

Open
matheusaleixo-cit wants to merge 20 commits into
GoogleCloudPlatform:mainfrom
matheusaleixo-cit:add-new-resource-for-network-policy-traffic-classification-rule
Open

Added new resources for "RegionNetworkPolicyTrafficClassificationRule" #18087
matheusaleixo-cit wants to merge 20 commits into
GoogleCloudPlatform:mainfrom
matheusaleixo-cit:add-new-resource-for-network-policy-traffic-classification-rule

Conversation

@matheusaleixo-cit

Copy link
Copy Markdown
Contributor

Adds new resource google_compute_region_network_policy_traffic_classification_rule.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_compute_region_network_policy_traffic_classification_rule`

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 25, 2026
@matheusaleixo-cit matheusaleixo-cit marked this pull request as ready for review June 25, 2026 16:23
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 25, 2026
@modular-magician

modular-magician commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f28d923:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 282 insertions(+)
google-beta provider View Diff 5 files changed, 1826 insertions(+)
terraform-google-conversion View Diff 1 file changed, 366 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_network_policy_traffic_classification_rule (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_policy_traffic_classification_rule" "primary" {
  action {
    type = # value needed
  }
  target_secure_tags {
    name = # value needed
  }
  target_service_accounts = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_region_network_policy_traffic_classification_rule

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
1504 1408 94 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeRegionNetworkPolicyTrafficClassificationRule_regionNetworkPolicyTrafficClassificationRuleBasicExample
  • TestAccComputeRegionNetworkPolicyTrafficClassificationRule_regionNetworkPolicyTrafficClassificationRuleBasicUpdate

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeRegionNetworkPolicyTrafficClassificationRule_regionNetworkPolicyTrafficClassificationRuleBasicExample
✅ Log TestAccComputeRegionNetworkPolicyTrafficClassificationRule_regionNetworkPolicyTrafficClassificationRuleBasicUpdate

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@matheusaleixo-cit, @malhotrasagar2212 VCR tests complete for f28d923!

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants