Add allowedServicePatterns to AccessContextManager ServicePerimeter by vmoros · Pull Request #18106 · GoogleCloudPlatform/magic-modules

vmoros · 2026-06-26T16:29:00Z

This PR adds support for service patterns in Access Context Manager service perimeters.

Internal links

Design doc: http://go/vpcsc-non-gcp-control-plane
This PR does for the main Google Terraform provider what cl/926899334 did for the nightly provider

accesscontextmanager: added `allowedServicePatterns` and `servicePatternsEnforcementScopes` fields to `ServicePerimeter` and `ServicePerimeters` resources

modular-magician · 2026-06-26T16:38:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2f03d69:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	23 files changed, 1398 insertions(+), 17 deletions(-)
`google-beta` provider	View Diff	23 files changed, 1398 insertions(+), 17 deletions(-)
`terraform-google-conversion`	View Diff	7 files changed, 521 insertions(+), 13 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter (15 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter" "primary" {
  spec {
    vpc_accessible_services {
      allowed_service_patterns {
        modifiers {
          add_request_header {
            key   = # value needed
            value = # value needed
          }
        }
        pattern = # value needed
        service = # value needed
      }
      service_patterns_enforcement_scopes = # value needed
    }
  }
  status {
    vpc_accessible_services {
      allowed_service_patterns {
        service = # value needed
      }
    }
  }
}

Resource: google_access_context_manager_service_perimeters (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeters" "primary" {
  service_perimeters {
    spec {
      vpc_accessible_services {
        allowed_service_patterns {
          modifiers {
            add_request_header {
              key   = # value needed
              value = # value needed
            }
          }
          pattern = # value needed
          service = # value needed
        }
        service_patterns_enforcement_scopes = # value needed
      }
    }
    status {
      vpc_accessible_services {
        allowed_service_patterns {
          service = # value needed
        }
      }
    }
  }
}

Test report

Analytics

Total Tests	Passed	Skipped	Affected
3	2	0	1

Affected Service Packages

accesscontextmanager

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccAccessContextManager

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	-	TestAccAccessContextManager/access_level
✅ Log	-	TestAccAccessContextManager/access_level_condition
✅ Log	-	TestAccAccessContextManager/access_level_custom
✅ Log	-	TestAccAccessContextManager/access_level_full
✅ Log	-	TestAccAccessContextManager/access_levels
✅ Log	-	TestAccAccessContextManager/access_policy
✅ Log	-	TestAccAccessContextManager/authorized_orgs_desc
✅ Log	-	TestAccAccessContextManager/data_source_access_policy_basic
✅ Log	-	TestAccAccessContextManager/gcp_user_access_binding
✅ Log	-	TestAccAccessContextManager/service_perimeter
✅ Log	-	TestAccAccessContextManager/service_perimeter_dry_run_egress_policy
✅ Log	-	TestAccAccessContextManager/service_perimeter_dry_run_ingress_policy
✅ Log	-	TestAccAccessContextManager/service_perimeter_dry_run_resource
✅ Log	-	TestAccAccessContextManager/service_perimeter_egress_policy
✅ Log	-	TestAccAccessContextManager/service_perimeter_egress_policy_update
✅ Log	-	TestAccAccessContextManager/service_perimeter_ingress_policy
✅ Log	-	TestAccAccessContextManager/service_perimeter_ingress_policy_update
✅ Log	-	TestAccAccessContextManager/service_perimeter_resource
✅ Log	-	TestAccAccessContextManager/service_perimeter_update
✅ Log	-	TestAccAccessContextManager/service_perimeters
❌ Error · Log	-	TestAccAccessContextManager/service_perimeter_nongcp_patterns
❌ Error · Log	-	TestAccAccessContextManager/service_perimeters_nongcp_patterns

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@vmoros VCR tests complete for 2f03d69!

modular-magician · 2026-06-26T17:29:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 20a5d7d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	23 files changed, 1446 insertions(+), 17 deletions(-)
`google-beta` provider	View Diff	23 files changed, 1446 insertions(+), 17 deletions(-)
`terraform-google-conversion`	View Diff	7 files changed, 521 insertions(+), 13 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
3	2	0	1

Affected Service Packages

accesscontextmanager

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccAccessContextManager

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	-	TestAccAccessContextManager/access_level
✅ Log	-	TestAccAccessContextManager/access_level_condition
✅ Log	-	TestAccAccessContextManager/access_level_custom
✅ Log	-	TestAccAccessContextManager/access_level_full
✅ Log	-	TestAccAccessContextManager/access_levels
✅ Log	-	TestAccAccessContextManager/access_policy
✅ Log	-	TestAccAccessContextManager/authorized_orgs_desc
✅ Log	-	TestAccAccessContextManager/data_source_access_policy_basic
✅ Log	-	TestAccAccessContextManager/gcp_user_access_binding
✅ Log	-	TestAccAccessContextManager/service_perimeter
✅ Log	-	TestAccAccessContextManager/service_perimeter_dry_run_egress_policy
✅ Log	-	TestAccAccessContextManager/service_perimeter_dry_run_ingress_policy
✅ Log	-	TestAccAccessContextManager/service_perimeter_dry_run_resource
✅ Log	-	TestAccAccessContextManager/service_perimeter_egress_policy
✅ Log	-	TestAccAccessContextManager/service_perimeter_egress_policy_update
✅ Log	-	TestAccAccessContextManager/service_perimeter_ingress_policy
✅ Log	-	TestAccAccessContextManager/service_perimeter_ingress_policy_update
✅ Log	-	TestAccAccessContextManager/service_perimeter_resource
✅ Log	-	TestAccAccessContextManager/service_perimeter_update
✅ Log	-	TestAccAccessContextManager/service_perimeters
❌ Error · Log	-	TestAccAccessContextManager/service_perimeter_nongcp_patterns
❌ Error · Log	-	TestAccAccessContextManager/service_perimeters_nongcp_patterns

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@vmoros VCR tests complete for 20a5d7d!

modular-magician · 2026-06-26T18:23:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 53a024a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	23 files changed, 1454 insertions(+), 17 deletions(-)
`google-beta` provider	View Diff	23 files changed, 1454 insertions(+), 17 deletions(-)
`terraform-google-conversion`	View Diff	7 files changed, 521 insertions(+), 13 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
3	2	0	1

Affected Service Packages

accesscontextmanager

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccAccessContextManager

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	-	TestAccAccessContextManager/access_level
✅ Log	-	TestAccAccessContextManager/access_level_condition
✅ Log	-	TestAccAccessContextManager/access_level_custom
✅ Log	-	TestAccAccessContextManager/access_level_full
✅ Log	-	TestAccAccessContextManager/access_levels
✅ Log	-	TestAccAccessContextManager/access_policy
✅ Log	-	TestAccAccessContextManager/authorized_orgs_desc
✅ Log	-	TestAccAccessContextManager/data_source_access_policy_basic
✅ Log	-	TestAccAccessContextManager/gcp_user_access_binding
✅ Log	-	TestAccAccessContextManager/service_perimeter
✅ Log	-	TestAccAccessContextManager/service_perimeter_dry_run_egress_policy
✅ Log	-	TestAccAccessContextManager/service_perimeter_dry_run_ingress_policy
✅ Log	-	TestAccAccessContextManager/service_perimeter_dry_run_resource
✅ Log	-	TestAccAccessContextManager/service_perimeter_egress_policy
✅ Log	-	TestAccAccessContextManager/service_perimeter_egress_policy_update
✅ Log	-	TestAccAccessContextManager/service_perimeter_ingress_policy
✅ Log	-	TestAccAccessContextManager/service_perimeter_ingress_policy_update
✅ Log	-	TestAccAccessContextManager/service_perimeter_resource
✅ Log	-	TestAccAccessContextManager/service_perimeter_update
✅ Log	-	TestAccAccessContextManager/service_perimeters
✅ Log	-	TestAccAccessContextManager/service_perimeters_nongcp_patterns
❌ Error · Log	-	TestAccAccessContextManager/service_perimeter_nongcp_patterns

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@vmoros VCR tests complete for 53a024a!

Add allowedServicePatterns to AccessContextManager ServicePerimeter

2f03d69

modular-magician added the service/accesscontextmanager label Jun 26, 2026

Ensure all new resources are covered in both status and spec

20a5d7d

Move use_explicit_dry_run_spec in tests

53a024a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add allowedServicePatterns to AccessContextManager ServicePerimeter#18106

Add allowedServicePatterns to AccessContextManager ServicePerimeter#18106
vmoros wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
vmoros:vgm-service-patterns-terraform

vmoros commented Jun 26, 2026 •

edited

Loading

Uh oh!

modular-magician commented Jun 26, 2026 •

edited

Loading

Uh oh!

modular-magician commented Jun 26, 2026 •

edited

Loading

Uh oh!

modular-magician commented Jun 26, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

vmoros commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Internal links

Uh oh!

modular-magician commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Missing test report

Test report

Analytics

Action taken

Uh oh!

modular-magician commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Test report

Analytics

Action taken

Uh oh!

modular-magician commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Test report

Analytics

Action taken

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vmoros commented Jun 26, 2026 •

edited

Loading

modular-magician commented Jun 26, 2026 •

edited

Loading

modular-magician commented Jun 26, 2026 •

edited

Loading

modular-magician commented Jun 26, 2026 •

edited

Loading