Add support for Chronicle Findings Refinement Deployment resource in GA#18111
Add support for Chronicle Findings Refinement Deployment resource in GA#18111nimam wants to merge 2 commits into
Conversation
nimam
commented
Jun 26, 2026
nimam
commented
Tested: TF_LOG=DEBUG TF_LOG_PATH=~/output.log make testacc TEST=./google/services/chronicle TESTARGS=' -run=TestAccChronicleFindingsRefinementDeployment*' sh -c "'/usr/local/google/home/naef/go/src/github.com/hashicorp/terraform-provider-google/scripts/gofmtcheck.sh'" ==> Checking that code complies with gofmt requirements... go vet go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20260610212136-7ab31c22f7ad go: downloading golang.org/x/net v0.56.0 go: downloading google.golang.org/api v0.285.0 go: downloading golang.org/x/sys v0.46.0 go: downloading golang.org/x/text v0.38.0 go: downloading golang.org/x/sync v0.21.0 go: downloading golang.org/x/crypto v0.53.0 TF_ACC_REFRESH_AFTER_APPLY=1 TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/chronicle -v -run=TestAccChronicleFindingsRefinementDeployment* -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc" go: downloading golang.org/x/mod v0.36.0 === RUN TestAccChronicleFindingsRefinementDeployment_chronicleFindingsRefinementDeploymentUpdateExample === PAUSE TestAccChronicleFindingsRefinementDeployment_chronicleFindingsRefinementDeploymentUpdateExample === CONT TestAccChronicleFindingsRefinementDeployment_chronicleFindingsRefinementDeploymentUpdateExample --- PASS: TestAccChronicleFindingsRefinementDeployment_chronicleFindingsRefinementDeploymentUpdateExample (59.85s) PASS ok github.com/hashicorp/terraform-provider-google/google/services/chronicle 60.601s
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b766e41: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportImportant Manual Verification Required (GA-only additions) The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually: 🔴 TestAccChronicleFindingsRefinementDeployment_chronicleFindingsRefinementDeploymentUpdateExample Analytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the replaying VCR build log @nimam, @slevenick, @ankitgoyal0301 VCR tests complete for b766e41! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c432af9: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportImportant Manual Verification Required (GA-only additions) The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually: 🔴 TestAccChronicleFindingsRefinementDeployment_chronicleFindingsRefinementDeploymentUpdateExample Analytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the replaying VCR build log @nimam, @slevenick, @ankitgoyal0301 VCR tests complete for c432af9! |
2 participants
