fix(#4198): use the placeholder colour for multiselect placeholder fallbacks - #4199
Open
twjeffery wants to merge 2 commits into
Open
fix(#4198): use the placeholder colour for multiselect placeholder fallbacks#4199twjeffery wants to merge 2 commits into
twjeffery wants to merge 2 commits into
Conversation
|
Preview links
Built from commit ea0a88f. Previews are removed automatically when this PR closes. |
ArakTaiRoth
reviewed
Aug 6, 2026
ArakTaiRoth
left a comment
ArakTaiRoth
left a comment
Collaborator
There was a problem hiding this comment.
This PR essentially isn't doing anything. I'm just looking at your created PR files in Angular.
- Dropdown and Dropdown Multiselect still have dark text for placeholder text
- Dropdown and Dropdown Multiselect still have greyed out text for selectable options
- Dropdown Multiselect also doesn't look as dark as it should?
- Disabled Dropdown is using the correct placeholder grey value, Dropdown error and Multiselect disabled aren't
I've attached pictures of the issues I raised above:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to GovAlta/design-tokens#171, which carries the actual colour change for issue #4198. Best reviewed together with that one.
What is here
The placeholder fallbacks. Two CSS fallback values in
DropdownMultiselect.sveltemove fromvar(--goa-input-color-text-default)tovar(--goa-input-color-text-placeholder), on.value-display.placeholderand.filter-input::placeholder. These are the fallbacks for--goa-dropdown-multiselect-color-text-placeholder. That token is defined, so the fallback never fires and this changes no rendering on its own. They are wrong on their own terms and this makes them honest.Playground pages at
bugs/4198in both the React and Angular playgrounds. Empty fields side by side across dropdown, multiselect, text input and text area, an empty field next to a filled one, an open menu, the multiselect whose options are deliberately unchanged, and the disabled and error states as a no drift check. Use the theme toggle in the nav for dark mode.One commit still to come
@abgov/design-tokens-v2is pinned at 2.12.0. Once #171 merges and publishes, this PR takes a one line bump to the published version, which is what actually makes the change visible to consuming teams.Flagging it up front so it is not a surprise after review. Until that commit lands the playground pages render the unfixed state, which is expected. Nothing else about this PR changes.
Notes
For anyone applying the Svelte change by hand,
var(--goa-input-color-text-default)appears five times in that file. The other three belong to--goa-dropdown-multiselect-color-text, the regular text colour, where falling back to the default is correct.Dark mode needs no work. The tokens resolve through greyscale values that the dark theme already overrides, so
dark-theme.csscame back byte identical from the tokens rebuild and is not in #171.