feat(#1731): Added a custom noResults property to Dropdown - #4204
Open
ArakTaiRoth wants to merge 1 commit into
Open
feat(#1731): Added a custom noResults property to Dropdown#4204ArakTaiRoth wants to merge 1 commit into
ArakTaiRoth wants to merge 1 commit into
Conversation
|
Preview links
Built from commit 178dc00. Previews are removed automatically when this PR closes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before (the change)
The default "No matches found" text when using
filterablefor the Dropdown component couldn't be changed.After (the change)
Now people can edit that message using the new
noResultsproperty.Also added an example on the main Dropdown component documentation page.
Make sure that you've checked the boxes below before you submit the PR
Steps needed to test
Use PRs feat1731 for both Angular and React to test.