Two bug fixes for per-app locale support#487
Open
thomasbuilds wants to merge 2 commits intoGrapheneOS:mainfrom
Open
Two bug fixes for per-app locale support#487thomasbuilds wants to merge 2 commits intoGrapheneOS:mainfrom
thomasbuilds wants to merge 2 commits intoGrapheneOS:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo: fix inverted isEmpty check for per-app locale split selection
The merge of per-app locales into the global locale set was guarded by
!pkgSpecificLocales.isEmpty, so it only ran when the list was empty. Per-app language preferences had no effect on language split APK selection.PackageStates: register locale-change receiver without package data scheme
ACTION_APPLICATION_LOCALE_CHANGEDcarries nopackage:data URI. Registering it in anIntentFilterwithaddDataScheme("package")caused Android to drop the broadcast, sopkgSpecificLocaleswas never refreshed when the user changed per-app language settings.