Repository navigation
refactor+test: persona data table, parser fuzz targets, hot-path benchmarks - #312
Merged
Merged
Conversation
BuiltinPersonas and CavecrewPersonas now iterate a package-level catalog and stamp timestamps per call, cloning slice fields so callers cannot mutate the shared data. Removes two 400-line literal constructors.
- FuzzParseSearchReplace (diff SEARCH/REPLACE parser + applier). - FuzzParseToolCallResult (MCP tool-result parser). - Benchmarks for IsSensitivePath, IsDestructiveCommand, validateShellCommand, and ParseSearchReplace. - Wire the two new fuzz targets into the CI fuzz gate.
Patel230
added a commit
that referenced
this pull request
Oct 2, 2026
…hmarks (#312) * refactor(agents): extract built-in persona catalog to a data table BuiltinPersonas and CavecrewPersonas now iterate a package-level catalog and stamp timestamps per call, cloning slice fields so callers cannot mutate the shared data. Removes two 400-line literal constructors. * test: add fuzz targets and benchmarks for model-facing parsers - FuzzParseSearchReplace (diff SEARCH/REPLACE parser + applier). - FuzzParseToolCallResult (MCP tool-result parser). - Benchmarks for IsSensitivePath, IsDestructiveCommand, validateShellCommand, and ParseSearchReplace. - Wire the two new fuzz targets into the CI fuzz gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuiltinPersonas/CavecrewPersonasnow iterate a package-level persona catalog and stamp timestamps per call, cloning slice fields so callers cannot mutate the shared data. Removes two ~400-line literal constructors.FuzzParseSearchReplace(diff SEARCH/REPLACE parser + applier) andFuzzParseToolCallResult(MCP tool-result parser); both wired into the CI fuzz gate.IsSensitivePath,IsDestructiveCommand,validateShellCommand,ParseSearchReplace. TheIsSensitivePathbenchmark surfaced ~22ms/op, worth a follow-up.Verified:
go vet,golangci-lint(0 issues), fullgo test ./...,make boundaries, fuzz targets run clean.