Repository navigation
refactor(tool): SchemaProperty minimum/maximum; migrate FuzzyFind - #321
Merged
Merged
Conversation
Extend SchemaProperty with Minimum/Maximum (interface{}, like Default, so
literals survive verbatim) plus an advisory range check in validateSchema
matching the existing soft-skip philosophy. Migrate FuzzyFindTool to a typed
FuzzyFindInput + Schema()-backed Parameters with parity tests locking the
limit bounds (1/100). Error text for malformed input changes from 'invalid
input' to the standard DecodeInput message; no test asserted the old string.
Patel230
added a commit
that referenced
this pull request
Oct 2, 2026
Extend SchemaProperty with Minimum/Maximum (interface{}, like Default, so
literals survive verbatim) plus an advisory range check in validateSchema
matching the existing soft-skip philosophy. Migrate FuzzyFindTool to a typed
FuzzyFindInput + Schema()-backed Parameters with parity tests locking the
limit bounds (1/100). Error text for malformed input changes from 'invalid
input' to the standard DecodeInput message; no test asserted the old string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #320 (typed tool schemas).
SchemaPropertywithMinimum/Maximum(kept asinterface{}, likeDefault, so literals survive verbatim) plus an advisory range check invalidateSchemamatching the existing soft-skip philosophy.FuzzyFindToolto typedFuzzyFindInput+Schema()-backedParameters()with parity tests locking the limit bounds (1/100). Malformed-input error text changes to the standardDecodeInputmessage; nothing asserted the old string.Verified:
go vet,golangci-linton the package (0 issues), fullinternal/toolsuite,gofmtclean.