fix: player name invisible in chatbox upon login#1095
Open
DesecratedTree wants to merge 3 commits into
Open
Conversation
Contributor
|
What an obscure bug. Interesting how you came to that one. |
Author
Just a minor annoyance I've been chasing for a while. Noticed it a few times while playing live server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: The chatbox CS2 script reads the player's name from the local player's appearance data. But the appearance data is only sent during the game tick via PlayerUpdateTask. The chatbox opens during spawn() before the first tick runs, so the client has no name and falls back to [quickchaticon].
Fix in AccountManager.kt:89: Added PlayerUpdateTask().run(player) after loadCallback (which adds the player to the viewport tracking set) but before player.open(gameFrame). This manually sends the player update (including appearance data with displayName) to the client before the chatbox opens.