Skip to content

add biohazard quest - #1260

Merged
GregHib merged 9 commits into
mainfrom
quest-branch
Sep 14, 2026
Merged

GregHib merged 9 commits into
mainfrom
quest-branch

Conversation

@Ebp90

@Ebp90 Ebp90 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Add the biohazard quest.

Plague sample removal needs to be checked.

Added a double gate method for automatic telewalk double gates.

Ports Biohazard: Elena's distillator, Jerico's pigeons and the watchtower
distraction, the rope ladder over the wall, the mourners' poisoned stew and
headquarters, the errand boys, Guidor's test and King Lathas' confession,
plus the Combat Training Camp the quest unlocks.

The mourners lose the drop table that handed out a full outfit every kill and
gain combat definitions of their own, taken from npc 370 in RuneScape-2011;
mourner_2 drops the quarters key while the stew has them laid up, and all
seven respawn.

Shared code touched along the way:

- Gate.replaceTogether, a fixed twin of Gate.replace, which walks the second
  half off the first half's new tile and turns both halves the same way. The
  original is left alone so the gates built around its placement don't move.
- Teleport.takeOff and teleportLand accept "*" and run every registered
  handler. Ghosts Ahoy's teleportTakeOff("*") was dead, and PirateTreasure
  and LostAndFound both registered teleportLand("modern"), so one silently
  overwrote the other.
- questprep gained prep_vars, for world state a prerequisite quest leaves
  behind that marking it complete doesn't reproduce.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WQ1FECKKC3ZpsGK3hNVVnh
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Qodana for JVM

10 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 10

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 58.93574% with 409 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.63%. Comparing base (d25c5dd) to head (bd8c7d7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...kotlin/content/quest/member/biohazard/Biohazard.kt 63.97% 69 Missing and 29 partials ⚠️
...otlin/content/quest/member/biohazard/ErrandBoys.kt 59.67% 39 Missing and 11 partials ⚠️
...in/kotlin/content/area/misthalin/varrock/Guidor.kt 50.50% 44 Missing and 5 partials ⚠️
...in/kotlin/content/area/kandarin/ardougne/Jerico.kt 37.87% 38 Missing and 3 partials ⚠️
...kotlin/content/area/asgarnia/rimmington/Chemist.kt 52.63% 32 Missing and 4 partials ⚠️
...tent/area/kandarin/ardougne/west_ardougne/Elena.kt 66.03% 34 Missing and 2 partials ⚠️
...otlin/content/quest/member/biohazard/RopeLadder.kt 52.23% 26 Missing and 6 partials ⚠️
...area/kandarin/ardougne/west_ardougne/NurseSarah.kt 41.02% 22 Missing and 1 partial ⚠️
...ome_stronghold/training_camp/CombatTrainingCamp.kt 35.29% 19 Missing and 3 partials ⚠️
...ent/area/misthalin/varrock/VarrockSouthEastGate.kt 73.91% 4 Missing and 2 partials ⚠️
... and 5 more
Additional details and impacted files
Files with missing lines Coverage Δ
...ea/kandarin/ardougne/west_ardougne/WestArdougne.kt 52.17% <100.00%> (+6.19%) ⬆️
...me/src/main/kotlin/content/entity/obj/door/Door.kt 52.41% <ø> (ø)
game/src/main/kotlin/content/quest/Quest.kt 69.01% <100.00%> (+0.44%) ⬆️
...tlin/world/gregs/voidps/cache/definition/Params.kt 0.00% <0.00%> (ø)
.../kotlin/content/area/kandarin/ardougne/Ardougne.kt 63.88% <85.71%> (+2.35%) ⬆️
...otlin/content/area/kandarin/ardougne/KingLathas.kt 92.00% <92.00%> (ø)
.../voidps/engine/entity/character/player/Teleport.kt 39.79% <44.44%> (-2.14%) ⬇️
...ame/src/main/kotlin/content/quest/QuestCommands.kt 68.00% <68.75%> (+1.33%) ⬆️
...ent/area/misthalin/varrock/VarrockSouthEastGate.kt 73.91% <73.91%> (ø)
...ome_stronghold/training_camp/CombatTrainingCamp.kt 35.29% <35.29%> (ø)
... and 8 more

... and 11 files with indirect coverage changes

@@             Coverage Diff              @@
##               main    #1260      +/-   ##
============================================
+ Coverage     44.45%   44.63%   +0.17%     
- Complexity    11114    11244     +130     
============================================
  Files          2120     2130      +10     
  Lines         98350    99325     +975     
  Branches      15877    15984     +107     
============================================
+ Hits          43726    44338     +612     
- Misses        48378    48678     +300     
- Partials       6246     6309      +63     
Components Coverage Δ
Content 45.14% <59.12%> (+0.23%) ⬆️
Engine 45.64% <44.44%> (-0.02%) ⬇️
Network 72.01% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib changed the title Biohazard add biohazard quest Sep 14, 2026
@GregHib
GregHib merged commit b01de42 into main Sep 14, 2026
5 checks passed
@GregHib
GregHib deleted the quest-branch branch September 14, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants