Restored functionality on all deposit boxes. - #1295
Merged
GregHib merged 4 commits intoSep 14, 2026
Merged
Conversation
GregHib
requested changes
Sep 14, 2026
Comment on lines
+224
to
+226
| # I'm identifying each of the remaining deposit boxes, the final number representing their string ID. | ||
| # I'm adding the string ID to the examine text to let us know that it's a lost deposit box, and needs to be properly assigned to an area. | ||
| # This allows all deposit boxes to work functionally, even if they're not all properly identified. |
Owner
There was a problem hiding this comment.
See: ObjectUsageFinder.kt to identify where they are in the world
Owner
There was a problem hiding this comment.
Alternatively we can also look at the official names
https://gameval.z-kris.com/#game=runescape&type=loc&cache=2670&q=%5E%286836%7C9398%7C20228%7C25937%7C39830%29%24&searchMode=regex&searchBehavior=filter
GregHib
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a small caveat, I haven't been able to properly identify which boxes are where, and instead of painstakingly tracking them down individually I added their ID to the examine text to help identify where they should go.
This started as an individual fix to the Ardougne deposit box, but since I could see the rest of the boxes that didn't have a string name attached to it, I thought it would be appropriate to at least restore functionality.