Fail startup reliably and order terminal process cleanup - #4
Merged
Merged
Conversation
This was referenced Sep 14, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if: >- | ||
| github.event_name == 'push' || | ||
| github.event_name == 'workflow_dispatch' || | ||
| (github.event_name == 'pull_request' && github.event.action == 'closed' && github.event.pull_request.merged == true) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed injector construction and asynchronous startup now fail readiness. The opt-in GuiceApplication process boundary waits for readiness, cleans up failed startup within a deadline, and makes process destruction terminal and idempotent. Destroy hooks use shutdown priority and class-name ordering without dropping tied providers.
Validation: Full injector suite: 12 tests passed, including four fresh-JVM readiness/failure/order probes. Earlier NE1 consumer checks exercised both main entry points, timeout/interruption, concurrent cleanup and failure deadlines; full domain startup remains unverified.
Companion dependencies: GuicedEE/Client#1.
Draft acceptance gate: review the coordinated library changes and build compatible artifacts before consumer CI or full local runtime acceptance. This PR does not publish Maven artifacts, migrate existing databases, or deploy applications.
Uses 2.2.3-SNAPSHOT to keep local validation separate from released 2.2.3 artifacts.
Consumer coordination: https://github.com/NE1-World/platform/pull/13.
Hosted CI: the initial builder failed before compilation because the shared Maven download URL returns 404. Prerequisite fix: GuicedEE/Workflows#1. Rerun CI after that reviewed change is integrated; local tests do not establish hosted CI success.
This PR also gates feature reviews to verification with skipDeploy=true; feature-branch pushes no longer invoke the deployment path.