Stop the release from masking its own error - #4
Merged
Merged
Conversation
Issues are disabled on this repo, so @semantic-release/github failed trying to file the failure report, hiding the real npm auth error underneath. Drops the now unused issues permission.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release job on main fails with
EINVALIDNPMTOKEN(npm answers401 Unauthorizedtowhoami), but the log ends with a different error:Issues has been disabled in this repository. That second failure comes from@semantic-release/githubtrying to open an issue to report the first one, and it buries the actual cause.failComment: false/failTitle: falseso a failed release reports the real error and nothing else.successComment: falsetoo, for the same reason on the happy path.issues: writepermission, which cannot be used with issues disabled.Does not fix the release itself: the
NPM_TOKENsecret is invalid or expired and has to be regenerated on npmjs.com. Unrelated to this change, the log also showsOIDC token exchange ... 404 package not found, which is just semantic-release trying trusted publishing before falling back to the token; it is harmless and goes away if trusted publishing is ever configured for the package.