Skip to content

Write immediate spring updates synchronously #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Guiw5 merged 1 commit into from
Sep 9, 2026
Merged

Write immediate spring updates synchronously #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions src/BottomSheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,14 +263,13 @@ export const BottomSheet = React.forwardRef<
})
}),
renderVisuallyHidden: fromPromise(async () => {
await asyncSet({
api.set({
y: defaultSnapRef.current,
ready: 0,
maxHeight: maxHeightRef.current,
maxSnap: maxSnapRef.current,
// Using defaultSnapRef instead of minSnapRef to avoid animating `height` on open
minSnap: defaultSnapRef.current,
immediate: true,
})
}),
activate: fromPromise(async () => {
Expand All @@ -289,25 +288,23 @@ export const BottomSheet = React.forwardRef<
}),
openImmediately: fromPromise(async () => {
heightRef.current = defaultSnapRef.current
await asyncSet({
api.set({
y: defaultSnapRef.current,
ready: 1,
maxHeight: maxHeightRef.current,
maxSnap: maxSnapRef.current,
// Using defaultSnapRef instead of minSnapRef to avoid animating `height` on open
minSnap: defaultSnapRef.current,
immediate: true,
})
}),
openSmoothly: fromPromise(async () => {
await asyncSet({
api.set({
y: 0,
ready: 1,
maxHeight: maxHeightRef.current,
maxSnap: maxSnapRef.current,
// Using defaultSnapRef instead of minSnapRef to avoid animating `height` on open
minSnap: defaultSnapRef.current,
immediate: true,
})

heightRef.current = defaultSnapRef.current
Expand Down Expand Up @@ -356,10 +353,7 @@ export const BottomSheet = React.forwardRef<
}),
closeSmoothly: fromPromise(async () => {
// Avoid animating the height property on close and stay within FLIP bounds by upping the minSnap
asyncSet({
minSnap: heightRef.current,
immediate: true,
})
api.set({ minSnap: heightRef.current })

heightRef.current = 0

Expand All @@ -370,11 +364,12 @@ export const BottomSheet = React.forwardRef<
immediate: prefersReducedMotion.current,
})

await asyncSet({ ready: 0, immediate: true })
api.set({ ready: 0 })
}),
},
}),
[
api,
ariaHiderRef,
asyncSet,
focusTrapRef,
Expand Down Expand Up @@ -584,13 +579,12 @@ export const BottomSheet = React.forwardRef<
return memo
}

api.start({
api.set({
y: newY,
ready: 1,
maxHeight: maxHeightRef.current,
maxSnap: maxSnapRef.current,
minSnap: minSnapRef.current,
immediate: true,
})

return memo
Expand Down